Feat/update map pin clusters #4012
Conversation
davehakkens
added
the
Review allow-preview ✅
|
I'd rather not have that test, tbh. |
|
@dalibormrska have a look on the preview link for any visual remarks https://community-platform-pr-4012.fly.dev/academy/intro.html |
|
Thanks for your first time contribution @johannes-ross! Yeah, I agree with @mariojsnunes about the test. I believe part of the issue is to use the right theme colour for the cluster too. Can you add that please. |
johannes-ross
temporarily deployed
to
preview
GitHub Actions
Inactive
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/4012
|
| Run status |
|
| Run duration | 05m 10s |
| Commit |
|
| Committer | Johannes Roß |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
74
|
| View all changes introduced in this branch ↗︎ | |
…colour based on theme
johannes-ross
temporarily deployed
to
preview
GitHub Actions
Inactive
|
As requested, I've removed the Test and added another functionality. The pin clusters now change colour based on theme. I'm guessing, that the assets folder is managed by Designers and not by developers. I've made it as dynamic as possible without changing the actual |
johannes-ross
temporarily deployed
to
preview
GitHub Actions
Inactive
|
I had a look, wow, really nice work! Even though I can only see the PP instance through the preview link, from me it's good to go. |
|
Fantastic! Thank you so much for your first contribution @johannes-ross! |
|
@all-contributors add @johannes-ross for code |
|
I've put up a pull request to add @johannes-ross! 🎉 |
|
Also rather belatedly! @all-contributors add @dalibormrska for design |
|
I've put up a pull request to add @dalibormrska! 🎉 |
|
🎉 This PR is included in version 2.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No Ring around Pin.
What is the new behavior?
When there is a cluster of people (a pin with a number in it) there will be a ring around it, with the corresponding theme colour.
Does this PR introduce a breaking change?
Git Issues
Closes #3855